Hiroshi Hatake
Hiroshi Hatake
Oh, our commit linter complains prefix issue in your commit: ❌ Commit 59cd7bbdd3 failed: Subject prefix 'in_blob:' does not match files changed. Expected one of: CMakeLists.txt:, build:, glob:, in_blob:, tests:...
If we proceed to address this issue, we need to send another PR into here https://github.com/chronosphereio/calyptia-plugin to handle event_type as well.
How about adding runtime shell test cases with precompiled Golang shared objects here? https://github.com/fluent/fluent-bit/tree/master/tests/runtime_shell Or, leaving as-is is still good but it tends to be delayed for reviewing without unit...
Plus, this PR still uses outdated base branch. So, could you rebase off the current master? No left device errors should be gone after rebasing off.
@coderabbitai review
The patches are really good but we need to add Signed-off line on each of commit. So, could you follow the instructions on this? https://github.com/fluent/fluent-bit/pull/11171/checks?check_run_id=55564201840
You can find built artifacts in https://github.com/fluent/fluent-bit/actions/runs/20140187371?pr=11270. This page provides RPM/DEB packages with PR 11270 patches for various Linux distributions.
I'm just wondering why the twice of applying multiline is needed in your conf: ```yaml pipeline: inputs: - name: tail storage.type: filesystem path: /var/log/containers/*.log db: /var/log/fb-storage/flb.db multiline.parser: docker, cri tag_regex:...
> > ### 💡 Codex Review > > https://github.com/fluent/fluent-bit/blob/0819c37314e40afad5801841e8993e4161a5806d/src/tls/openssl.c#L804-L808 > > > > ** mTLS now forced for TLS inputs using default verify** > > When `verify` is enabled...
> **commit message with in_kubernetes_events: tests:** > > ``` > in_kubernetes_events: tests: missing db config options > > Subject prefix 'in_kubernetes_events:' does not match files changed. > Expected one of:...