Cosimo Lupo

Hi @mdenker, thanks for summarizing so thoroughly the points of discussions we went through yesterday. As soon as possible, I will implement these new guidelines in the CWL development branch...

Also, the following figures need to be uploaded on the main public repository (i.e. this one), and properly linked in the file `cobrawap/pipeline/README.rst`, instead of pointing at an external repository:...

@rgutzen Ok, I'm fine with splitting this PR into two different ones, so to have a better traceability of changes: one fixing the two typos (which are not the least...

Hi all, I'm one of the developers of a fairly large workflow for neuroscience data analysis (https://github.com/NeuralEnsemble/cobrawap). I already had the great occasion to meet in person @mr-c in 2023...

@rgutzen, indeed I found it, but forgot to link here. Thanks, it's useful to have it here.

@mdenker this issue seems to have been solved by PR #70, which has been already merged and included in the v0.2.0. Can we mark it as closed?

@rgutzen why is it important for `vector_frames` to have the same shape as `frames`? Is this feature explicitly or implicitly used somewhere downstream in the code?

Here a test about the new implementation of phase_conv2d, compared to the old implementation (after having fixed the bug as in PR #66):  The difference between them stays below...