Carlos O'Ryan

Results 588 comments of Carlos O'Ryan

@hitesh-kumain if you are interested, consider sending a PR to fix *part* of this bug. It would be useful to have a way to validate OIDC tokens, as such code...

Thanks for the PR! I have started the CI builds, let's see how they go.

> I can't see the failures. There is a link to public logs in a previous comment: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/9466/da4c213d1cde2d68937fde1a09ac6718c46ea0f6/index.html > What version of Bazel does your project use? "use_cpp_toolchains" was added...

> Looks like the issue is actually rules_cc, which hasn't yet released the changes with `use_cpp_toolchain`. If I can get them to do a new release, will that be something...

@katre have you heard back? If not, maybe we should close this PR until we have some clarity?

> Can this stay open until early next week? Sure, no problem. I suspect you will need to rebase, we have changed the builds since you started the PR.

In case you missed it, the robots sent us #9572 to update rules_cc. It failed with the oldest version of Bazel we support (4.2): https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/9572/f8b726915a67c676f6d414c672abf097e65c4719/fedora-36-bazel-oldest/log-f6435d74-72db-403c-b8f4-0313c1e267e2.txt We will drop support for...

Still waiting for the passage of time.