Andreas Coroiu

Sorry for dismissing my approval but I just noticed something in the figma design when it comes to the paddings Here is the design for the tab component (which your...

I'm gonna split this into two PRs so I'm only gonna answer the first questions here: > What are the motivations for having a regular button with the loading effect?...

If I'm being honest the main reason for me making these changes were because I thought they were necessary to implement https://github.com/bitwarden/clients/pull/3548. But now that I've thought about it I'm...

@Hinton it's already being used in a few places, though we could replace them. Either way I think I really need to get these PRs merged, what would the QA...

Comment from @Hinton in https://github.com/bitwarden/clients/pull/3537 > I think it's a good refactor, it will certainly let us get rid of the annoying form promises we create everywhere. I'm unsure of...

Currently waiting to merge base branch, will then update this and prepare it for review

> I do think we need to document this thoroughly. What are your thoughts on adding descriptions to each story + some comments to the directives, and writing a markdown...

@bitwarden/dept-design None of our ng-select-based solutions have backgrounds for selected options, do we want to do something about that? Multi-select at least has a checkmark which makes it easier to...

@danielleflinn done! [CL-77 [Bug ?] Multi-select dropdown is missing hover state on selected items](https://bitwarden.atlassian.net/browse/CL-77)

Now this stopped working for me. I think this will have to wait until after OAVR v2