clients icon indicating copy to clipboard operation
clients copied to clipboard

[EC-667] Collection modal add search function

Open coroiu opened this issue 2 years ago • 4 comments

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add new searchable select to collection dialog. This implementation is a quick fix and we need to address the fact that we now have two different select implementations: multi-select and the regular select. The latter is not defined in the figma CL documentation.

This new select also depends on the css rules defined by multi-select. We should look into either merging these components or at least moving them into the same module.

Screenshots

image

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

coroiu avatar Dec 21 '22 13:12 coroiu

@bitwarden/dept-design None of our ng-select-based solutions have backgrounds for selected options, do we want to do something about that? Multi-select at least has a checkmark which makes it easier to identify selected items, but it's still odd that the hover effect is not present on selected items

coroiu avatar Dec 21 '22 14:12 coroiu

@coroiu good call; can you add a story to the jira Component Library board?

danielleflinn avatar Dec 21 '22 16:12 danielleflinn

Now this stopped working for me. I think this will have to wait until after OAVR v2

coroiu avatar Dec 23 '22 10:12 coroiu

@shane-melton good catch! I've fixed the issue and double checked that the CSP hash has not changed (I have no idea how those hashes work... 🤷)

coroiu avatar Jan 26 '23 12:01 coroiu