clients
clients copied to clipboard
[EC-667] Collection modal add search function
Type of change
- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
Objective
Add new searchable select to collection dialog. This implementation is a quick fix and we need to address the fact that we now have two different select implementations: multi-select and the regular select. The latter is not defined in the figma CL documentation.
This new select also depends on the css rules defined by multi-select
. We should look into either merging these components or at least moving them into the same module.
Screenshots
Before you submit
- Please add unit tests where it makes sense to do so (encouraged but not required)
- If this change requires a documentation update - notify the documentation team
- If this change has particular deployment requirements - notify the DevOps team
@bitwarden/dept-design None of our ng-select-based solutions have backgrounds for selected options, do we want to do something about that? Multi-select at least has a checkmark which makes it easier to identify selected items, but it's still odd that the hover effect is not present on selected items
@coroiu good call; can you add a story to the jira Component Library board?
@danielleflinn done! CL-77 [Bug ?] Multi-select dropdown is missing hover state on selected items
Now this stopped working for me. I think this will have to wait until after OAVR v2
@shane-melton good catch! I've fixed the issue and double checked that the CSP hash has not changed (I have no idea how those hashes work... 🤷)