Jeeyong Um

Results 8 comments of Jeeyong Um

https://imgur.com/a/NyIvfVX This is a screenshot of modal popup provided by universal authenticator. In normal scenario, it activates "Scatter" button after connecting to scatter, but it keep showing process dots (...)...

It seems internal `boost::pfr` fails to deduce the type. This kind of error can usually be fixed by declaring EOSLIB_SERIALIZE() macro manually. ``` c++ TABLE messages { name user; eosio::signed_int...

Can you assign anyone who may review this? It would be good if I can get a review before writing test cases. - API design - Additional feature for recovering...

@heifner Thank you for the review. What do you think of recovering uncompressed public key for recovery ID from 27 to 30?

``` c __attribute__((eosio_wasm_import)) int recover_key( const struct capi_checksum256* digest, const char* sig, size_t siglen, char* pub, size_t publen ); ``` By default, C API is not accessible any more. Your...

@vasama I think so, but P0323R11 defines four overloads for `std::expected::value()`: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p0323r11.html#expected.expected According to P0323R11, it's not clear how `std::expected::value()` should work, but original author's implementation also doesn't throw an...

@vasama > On further inspection, I was wrong about the overloads being redundant. The `&&` overload moves the error object when throwing it. Thank you for letting me know. >...

@vasama Ah, you are right. I forgot considering that case.