Conor Evans

Results 12 comments of Conor Evans

yep @obrienmd realized that a moment too late 😅 (I removed my comment)

Hi @sjwang90 as an external contributor, I marked it as draft to show it needed some early feedback (in case the approach I took was terrible). I left some comments...

Hi @iarkhanhelsky thanks to @sjwang90 and @reimda pushing this forward I will look to make their requested changes and update this.

Hi @reimda @sspaink @Hipska this should be good now 🤞

@agayev169 according to the blog post at https://jdkato.medium.com/introducing-prose-v2-0-0-bringing-nlp-to-go-a1f0c121e4a5: > In order to avoid breaking code already importing prose, v2.0.0 will be exposed via gopkg.in/jdkato/prose.v2— allowing github.com/jdkato/prose to still point to...

Hmm ok, re-reading, `MetricFamily.Type` cannot legitimately be nil. So far I see a few options (going to try to look for a better one) - if `in.Help` is nil, we...

Couldn't reproduce this. ```zsh % helm install --set serviceMonitor.enabled=true --dry-run grafana ./ | grep -A 5 -B 2 ServiceMonitor # Source: grafana/templates/servicemonitor.yaml apiVersion: monitoring.coreos.com/v1 kind: ServiceMonitor metadata: name: grafana namespace:...