fix(agent): watch for changes in configuration files in config directories

[conorevans]

Signed-off-by: Conor Evans [email protected]

Required for all PRs:

• [ ] Updated associated README.md. [I don't think this is necessary]
• [ ] Wrote appropriate unit tests. [TODO]
• [x] Pull request title or commits are in conventional commit format [when I do tests and stuff I will squash the commits into one that follows this convention.

resolves #9985

The walkfn is virtually identical to config.LoadDirectory() - I chose duplication over abstraction, as I think the scope for the latter is limited and undesirable.

[telegraf-tiger[bot]]

Thanks so much for the pull request! :handshake: :black_nib: Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

[conorevans]

!signed-cla

[telegraf-tiger[bot]]

:thumbsup: This pull request doesn't change the Telegraf binary size

:package: Looks like new artifacts were built from this PR.

Expand this list to get them here ! :tiger:

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

[sjwang90]

@conorevans This PR is still named draft. Is this ready for review?

[conorevans]

Hi @sjwang90 as an external contributor, I marked it as draft to show it needed some early feedback (in case the approach I took was terrible). I left some comments as to the things I though maintainers might like to comment on, but it's remained inactive. I can remove the draft label if that would make it more obvious that it needed feedback?

[sjwang90]

Yeah - go ahead and remove the draft title and I'll mention it to the maintainers to do a review.

[iarkhanhelsky]

@sjwang90 @Hipska @conorevans Hi all! Any chance to make this PR merged? I'll be glad to help if any help is needed.

[conorevans]

Hi @iarkhanhelsky thanks to @sjwang90 and @reimda pushing this forward I will look to make their requested changes and update this.

[shruthikudlur]

Does this code also watch for new files added into the dierctory?

[reimda]

Does this code also watch for new files added into the dierctory?

It only watches the files that were in the directory when telegraf loads its config. You would need to restart or sighup telegraf to watch new files.

[sspaink]

@conorevans If you fix the failing tests we can get this merged, thank you for your hard work!

It is failing with: cmd/telegraf/telegraf.go:388:11: cannot use &fConfigs (value of type *[]string) as flag.Value value in argument to flag.Var: *[]string does not implement flag.Value (missing method Set)

Looks like we need to keep the fConfigs to be sliceFlags and not []strings

[conorevans]

Hi @reimda @sspaink @Hipska this should be good now 🤞

[telegraf-tiger[bot]]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.

:relaxed: This pull request doesn't significantly change the Telegraf binary size (less than 1%)

:package: Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

[sspaink]

Closing as this PR has been replaced by: https://github.com/influxdata/telegraf/pull/12127