Connor Clark

Fix usage of pack_fseek in dumb_packfile_skip

5

According to the Allegro 4 docs, the second argument to [pack_fseek](https://www.allegro.cc/manual/4/api/file-and-compression-routines/pack_fseek) denotes a relative offset, but dumb assumes it is an absolute offset. This resulted in a bug where music...

The specific id for the execution context varies as Chrome internals does different work before we even begin Lighthouse gathering, and has already changed twice recently. Instead of using the...

address a few esmodule TODOs

1

This PR is meant to be merged without squashing. Going through some of the `TODO(esmodules)` comments, each commit here addresses a separate thing (so you should view each commit in...

tests: sequester mocks to `-test.mocks.js` files

3

The purpose of this refactor is to avoid needing to think deeply about the module graph when mocking modules in a test. Since static imports are run _first_ in ESM,...

Update mobile preset to match newer devices

2

https://twitter.com/patrickhulce/status/1554163245937737730 viewport, DPR, UA (but not CPU multiplier) see also: https://github.com/GoogleChrome/lighthouse/issues/10741#issuecomment-626903508 about DPR

misc: document where network timings come from

1

Paul and I attempted to document where all these timings come from in our network record model, in relation to the box-whisker model from DevTools performance panel.

misc: re-enable pubads after esm migration

4

This PR converted to ESM: https://github.com/googleads/publisher-ads-lighthouse-plugin/pull/354

https://github.com/GoogleChrome/lighthouse/blob/1e567c2102980d9abe070aa9fc3e7314f54d8c46/lighthouse-core/config/config.js#L129-L149

It was removed as part of the ES module migration. We need to update that repo to use ES modules.

Add smoke test for user flows

1

First idea is to add a `callback/runner/idk` property to smoke test definition that takes a `page` and `flow` and runs a user flow for that. Adam points out it may...