lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard
verified publisher icon GoogleChrome

misc: re-enable pubads after esm migration

Open connorjclark opened this issue 3 years ago • 4 comments

This PR converted to ESM: https://github.com/googleads/publisher-ads-lighthouse-plugin/pull/354

connorjclark avatar Jul 27 '22 20:07 connorjclark

Wut?

Screen Shot 2022-07-27 at 1 41 56 PM

adamraine avatar Jul 27 '22 20:07 adamraine

Wut?

Somehow the permissions of that file changed locally...

connorjclark avatar Jul 27 '22 21:07 connorjclark

These changes landed in their main branch, so we can land this now and get pubads back into our CI.

connorjclark avatar Jul 29 '22 20:07 connorjclark

We may want to sit on this for awhile, until more TODO(esmodules) stuff have landed and other necessary changes are found/made.

connorjclark avatar Aug 02 '22 19:08 connorjclark