Saleem Abdulrasool

Results 121 comments of Saleem Abdulrasool

Completely agreed @keith! I think that we should take another pass at the CI situation for Windows with 5.10. The installer was completely overhauled and now does per-user installation, so...

@keith okay, the install issue is resolved, but now the problem is that `Path` and `SDKROOT` are not in the environment, and I don't see how to get that added...

I suppose that they should be - the installer is installing into a user specific location - `%LocalAppData%\Programs\Swift\Toolchains\%SwiftVersion%+Asserts\usr\bin`, the runtime is located at `%LocalAppData%\Programs\Swift\Runtimes\%SwiftVersion%\usr\bin` and SDKROOT can be assumed to...

@keith I'm not sure how to make the appropriate changes for this, so a bit of guidance would be appreciated.

I'm not too fond of the approach, but it does get further: ``` Auto-Configuration Error: Setting up VC environment variables failed, WINDOWSSDKDIR is not set by the following command: --  ...

Well, that seems like something that general Windows support should have figured out. I'm not sure what is going on, but it seems that we are missing something in the...

Yeah, exactly, it seems like that is what is needed.

@tomerd wanted to make progress on adopting System for SPM, and we need to resolve this (along with the other test failures). I've since paged a lot of the path...

I agree that discarding unknown databases seems reasonable (and potentially even for the ones that we know about but do not support, i.e. everything but `passwd` and `group`). But, that...