commenthol

Results 83 comments of commenthol

@giuseppeturelli Sorry for breaking your build. I did not thought about es2015 compatibility.

Just wanted to share how I got eslint-config-standard working with eslint@9. install dev dependencies ``` npm i -D eslint@^9 eslint-config-standard@^17 eslint-plugin-import@^2 eslint-plugin-n@^17 eslint-plugin-promise@^6 ``` then change `eslint.config.js` ```js import globals...

PR is a duplicate of #482

Hi @1valdis, I am personally not interested in rewriting this lib to TS as IMO this is a hell of work. I understand the need of typing's from a DX...

Hi @1valdis, I'd like to say that I won't maintain a refactoring using typescript files within this project. If you like to add jsdoc comments or .d.ts typescript declarations feel...

Hi @hweejae-shin, Thanks for your PR. Can you please check why the tests are failing? Please consider updating the fixtures with (See CONTRIBUTING.md): ```sh npx mocha test/all.mocha.js --writetests --countries HK...

PR was manually merged with commit https://github.com/commenthol/date-holidays/commit/86af1fa2d99d315e6f9a8e9d7034664b0e3f57a4

Hi @sumantelus, Family Day is not observed in all provinces. I checked with https://en.wikipedia.org/wiki/Family_Day_(Canada) and Family Day seams to be missing in "New Brunswick" only. - [x] Alberta - [x]...

Hi @Pepebuho, can you create a PR on the desired changes?

PR means "Pull Request". See https://github.com/commenthol/date-holidays/pulls?q=is%3Apr+is%3Aclosed to get some inspiration from old contributions. Before starting please read the [Specification](https://github.com/commenthol/date-holidays/blob/master/docs/specification.md) to understand the YAML syntax being used, as well as the...