date-holidays icon indicating copy to clipboard operation
date-holidays copied to clipboard
verified publisher icon commenthol

Change Korean Thanksgiving Day

Open hweejae-shin opened this issue 1 year ago • 1 comments

Why Change

  • South Korea observes a holiday for the day before and the day after Chuseok.
  • However, the current data shows a three-day holiday from Chuseok itself.
  • Therefore, the data should be modified to reflect a three-day holiday starting from the day before Chuseok.

Reference

  • https://en.wikipedia.org/wiki/Chuseok image

What Change

  • Change Korean Thanksgiving Day data
  • Update the unimplemented test code

hweejae-shin avatar Jun 28 '24 07:06 hweejae-shin

Hi @hweejae-shin, Thanks for your PR. Can you please check why the tests are failing? Please consider updating the fixtures with (See CONTRIBUTING.md):

npx mocha test/all.mocha.js --writetests --countries HK

commenthol avatar Nov 26 '24 18:11 commenthol

PR was manually merged with commit https://github.com/commenthol/date-holidays/commit/86af1fa2d99d315e6f9a8e9d7034664b0e3f57a4

commenthol avatar Oct 26 '25 10:10 commenthol