uap-core icon indicating copy to clipboard operation
uap-core copied to clipboard
verified publisher icon ua-parser

Rename 'Mac OS X' to 'macOS'

Open mbeijen opened this issue 3 years ago • 4 comments

Since 2016 it's officially named macOS: https://en.wikipedia.org/wiki/MacOS

This is a separate change similar to the PR which has been open for a while and which has merge conflicts:

https://github.com/ua-parser/uap-core/pull/482

Also my version comes with less gratuitous whitespace changes :D

mbeijen avatar Jan 09 '23 21:01 mbeijen

PR is a duplicate of #482

commenthol avatar Jan 11 '23 07:01 commenthol

PR is a duplicate of #482

Yes indeed, I noted this in my original message. But that PR got stuck and has a merge conflict and I wanted to get this issue fixed, so I decided to make a new, similar one.

mbeijen avatar Jan 11 '23 08:01 mbeijen

Hi @commenthol , can you look at this PR please?

mbeijen avatar Feb 09 '23 09:02 mbeijen

I don't think this is a good idea. Such a change would break any code that depends on the specific string Mac OS X produced by the specific UA parser they use. Personally, I would prioritize the continued functioning of code depending on this more important than updating to a vendor's latest preferred branding.

akrennmair avatar Sep 20 '23 15:09 akrennmair