Côme Chilliet
Côme Chilliet
> > I insist that it should use the new config value instead of the config.php owner if the value is filled. Is if php.user is empty, it checks that...
Not completely happy about it but too much time was spend already, and it does fix the usecase.
> Code looks good! How will this be used? Plan is to use that for integration of an external workflow engine, but architecture is not final yet. One problem is...
Webhooks are moved to an application with registrations in DB instead. They will also need to support filtering of events triggerring the webhook. - [x] Skeleton app - [x] API...
- [x] Store app id from appapi header if available
To test current version: 1 - register a webhook, for instance: ```php
Follow-up: - [ ] Extract user filter from eventFilter so that the listener is not even registered depending on logged in user - [ ] Same for group membership
> It seems the node events that you added the interface to are not actually emitted at the moment. I can only see the old `\\OCP\\Files::preWrite` ones They are, I...
- [x] webhooks app id is already used on appstore, we should rename.
> Is this route actually used in NC28? > > The security headers check was migrated in NC29. Previously `OC.generateUrl('heartbeat')` was used. It’s cleaner to have the route in the...