Côme Chilliet
Côme Chilliet
> Additionally, summarizing the number of failures somewhere at the end would prevent errors from being unseen from scrolling of the screen with large verbose outputs. Added an error counter.
> To be honest I do not really know, I also wondered the same, but I just followed the existing code shrug Don’t do that, fix the existing code! But...
@icewind1991 So, this is currently broken, because opening with mode `r+` does not touch the header. See https://github.com/nextcloud/server/blob/master/lib/private/Files/Stream/Encryption.php#L287-L292 Same problem in https://github.com/nextcloud/server/blob/master/apps/encryption/lib/Crypto/Encryption.php#L221-L225 Is `r+` mode supported at all by server...
So, I was not able to do this in a smart way, in the end the whole file has to be written again anyway since the header at the beginning...
Ok this is now working and not losing fileid anymore. It will be slow sadly but I do not see how to avoid that. Ready for review.
CI failures not related
Rebased on master but tests are failing, not clear why. Something in the changes is breaking DB somehow.
People with the issue, could you give the output of `php --info|grep -i sqlite` ? (using the same php that runs the nextcloud server). Also `php --version`.
> Request 2: `$ **php --version** PHP 5.4.16 (cli) (built: Apr 1 2020 04:07:17) Copyright (c) 1997-2013 The PHP Group Zend Engine v2.4.0, Copyright (c) 1998-2013 Zend Technologies with the...