Colm

Results 30 comments of Colm

@onurctirtir this problem (and both #7697 and #7696) does not occur with Citus 13 and on investigation the problem is with Postgres 16, because of pg commit [695f5deb79](https://github.com/postgres/postgres/commit/695f5deb7902865901eb2d50a70523af655c3a00), which prevents...

> I didn't have time to check the regression tests, but I assume @colm-mchugh already reviewed them. But besides that, the implementation part looks good to me, thank you! >...

@c2main Thanks for your work on this, we appreciate your reworking the fix to apply it in the distributed planner hook. We would like the fix to be detected and...

> > However, adding my rewrite function just before `PlanRouterQuery()` in `RouterJob()` does the job. > Nice. > Maybe it's possible to push down a bit more in `PlanRouterQuery()` but...

> > There is very probably a design choice to be made, if possible not by me but Citus committers on what contract Citus want to have with parser tree...

> > Thank you for the feedback @colm-mchugh. > > FYI I am still studying alternative ways to achieve the goal, including hook mentioned. Also a step back to look...

> Yeah, I appreciated the preliminary comment in this deparse.c file. You saw [this one which looks a good description of the problem](https://github.com/postgres/postgres/blob/761c79508e7fbc33c1b11754bdde4bd03ce9cbb3/contrib/postgres_fdw/deparse.c#L480) > > > I also have a...

@c2main we'd like get this into the upcoming release Citus 13.1, so just want to check if it is possible for you to rebase onto the current main branch, taking...