Collin Funk
Collin Funk
Hi, I looked into this a bit. The value `\r` used to exist when the variable was added in https://github.com/python/cpython/commit/e9387ea773cdffeac5aa8ca094471bfc38ff6d03. It was removed in https://github.com/python/cpython/commit/eca20b611433fac88057da092efc0b6d6d2a7fb3. It was a merge from...
@bsdimp @emaste ISO C 23 N2826 adds the function-like macro unreachable() to stddef.h. Can I submit a separate patch proposing that change? I'm not sure if it is something left...
> this needs one commit per subsystem. Oops, my bad. Split into three commits, one for each program.
> short term NAK on this (leave the PR open). We need to be careful about namespace pollution and I'd like to start marking those glibc extensions that are likely...
> Oh, then remove my NAK hold if others can verify this. Maybe add `if __BSD_VISIBLE || __XSI_VISIBLE >= 800` (the latter of which we don't actually set). Sure, that...
Sorry, I saw this a bit late. Thanks for making that change for me.
> this seems sensible. I'm surprised it's not been throwing a warning I think it might have thrown -Wsign-compare if it started to be used for comparison. I assume that's...
I think that the links to atoi_l and friends should remain in xlocale(3). Some of the other ones on that page are also missing (e.g. strtol_l, wcstol_l). As long as...
Two of the style(9) failures are from the weird GETC macro. The others are because I did not add previously missing parentheses around return values. Should I amend or leave...
That should be all of them hopefully...