Colin Rotherham

Results 71 issues of Colin Rotherham

Work in progress PR to move key attributes into `govukAttributes()` Due to improved checks for `null`, `undefined` or empty `""` this closes https://github.com/alphagov/govuk-frontend/issues/4669 To help discuss, I've picked these components...

nunjucks

This PR migrates our component data YAML into ES modules to: 1. Run type checks using TypeScript 2. Run code quality checks using ESLint 3. In future, import typed examples...

assurance
interoperability

Another thing worth a quick spike We've added extra reasons for the **Tabs** component to fail initialisation now `ElementError` is thrown Since all of these are in control, could we...

## Context Our Markdown heading ID plugin `marked-gfm-heading-id` has been updated with a new new export `getHeadingList()` which means we could remove [`extractPageHeadings()`](https://github.com/alphagov/govuk-design-system/blob/a8a868badf95530066fb0dc015287a8dc7d8bc15/lib/extract-page-headings/index.js#L11) in future Raising this issue so we...

tooling

For recent contributions I've been running with a [**jsconfig.json**](https://code.visualstudio.com/docs/languages/jsconfig) file It's helped me find and fix a few things but there's no necessity to merge ### Code autocomplete This PR...

Hello 👋 We’ve noticed for a while that prototype kit and GOV.UK Frontend examples keep the “Back link” and “Phase banner” outside landmark regions. i.e. They’re not in a ``,...

accessibility
🕔 hours
Question: decision-making
needs research

The following countries/territories can't be selected if you type the hyphen: ``` Guinea-Bissau Ras al-Khaimah Saint-Martin (French part) Umm al-Quwain ``` Before you type the hyphen, you can choose an...

Hello 👋 There might be some history behind this, but I noticed small checkboxes use the regular divider width (unlike radios) This PR ensures checkboxes follow the same convention as...

## What This issue has been created to investigate using polyfills from an npm package We currently copy polyfills from: 1. https://polyfill.io web service 2. [`polyfill-library`](https://www.npmjs.com/package/polyfill-library) npm package 3. [MDN...

javascript

Hello 👋 Thought I'd share a little improvement added in [TypeScript 5.5: JSDoc `@import` tag](https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/#the-jsdoc-import-tag) Should prevent `@typedef` re-exporting private/internal definitions in https://github.com/alphagov/govuk-frontend/issues/5157 by using `@import` instead