Colin Rotherham

For discussion: Strategies to reduce GitHub workflow runs (+ Percy)

1

Just adding some GitHub Action workflow tweaks here ### Ideas so far **Cancel in-progress GitHub workflows when pushed again** Forgot a change? Pushing up a second time with cancel the...

Use async file operations for helpers

1

This PR aims to remove IO blocking `readFileSync()` calls (including component directory listings) Puppeteer tests are running super quickly 😊 https://user-images.githubusercontent.com/415517/191203826-04de51dc-f34f-431e-8042-ab45bf0effeb.mp4

I noticed when we build to a custom directory via `--destination` it's not "cleaned" ``` npx gulp build:package --destination 'custom/location/package' npx gulp build:dist --destination 'custom/location/dist' ``` ☝️ As those two...

In response to [comment regarding ***.js** files in `govuk-esm`](https://github.com/alphagov/govuk-frontend/pull/2851#issuecomment-1254698677) >So I think we can just remove the `${configPaths.src}**/*.js` glob from the `js:copy-esm` task? This PR includes: 1. Combine `js:copy-esm` task...

Separate out CSS/JS lint tasks from `copy-assets`

1

This PR does a few things: 1. Renames `gulp copy-assets` → **`gulp compile`** for clarity 2. Renames `gulp copy-files` to **`gulp copy:files`** for consistency 3. Separates out CSS/JS lint tasks...

Unlike how we compile Sass, we don't add [`gulp-plumber`](https://github.com/floatdrop/gulp-plumber#readme) to the JavaScript compile **compileStyles ()** via `gulp scss:compile` Notice how errors are caught by plumber and logged by `errorHandler`? ```js...

Add ESLint and Stylelint caches to GitHub actions workflow

1

During workflow runs we only need to lint "changed" files Both ESLint and Stylelint support this 👍 Locally too, this will remove a 2-3 second delay during (future) git hook...

Splitting out the "Fix webpack docs" commit from https://github.com/alphagov/govuk-frontend/pull/2863 into this one I've made these changes by hand so needs a bit of scrutiny

1. Fix JS error in Hungarian translation 2. Use PostCSS to add vendor prefixes (e.g. `-webkit-`, `-ms-`) 3. Use `` tag for each face, not empty links `` 4. Use...