govuk-frontend icon indicating copy to clipboard operation
govuk-frontend copied to clipboard

[WIP] Move component attributes into `govukAttributes()`

Open colinrotherham opened this issue 2 years ago • 1 comments

Work in progress PR to move key attributes into govukAttributes()

Due to improved checks for null, undefined or empty "" this closes https://github.com/alphagov/govuk-frontend/issues/4669

To help discuss, I've picked these components so far:

  • Button
  • ~Character count~ https://github.com/alphagov/govuk-frontend/pull/4566/commits/b93ef7bce5c7f47fe4318698e173b4c342ae599a
  • Input

colinrotherham avatar Feb 16 '24 15:02 colinrotherham

:clipboard: Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 112.86 KiB
dist/govuk-frontend-development.min.js 38.53 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 78.63 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 73.89 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 112.85 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 38.51 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.38 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 70.21 KiB 36.78 KiB
accordion.mjs 21.67 KiB 12.42 KiB
button.mjs 4.67 KiB 2.16 KiB
character-count.mjs 21.24 KiB 9.45 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 6.57 KiB 2.92 KiB
exit-this-page.mjs 16.04 KiB 8.86 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 4.93 KiB 2.09 KiB
radios.mjs 4.83 KiB 2.38 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.13 KiB 6.11 KiB

View stats and visualisations on the review app


Action run for 2affb93ad6f55016257183fdf4703ab8e1314491

github-actions[bot] avatar Feb 16 '24 15:02 github-actions[bot]