Colin O'Dell
Colin O'Dell
Downgrading to Lumen 5.1.7 and develpr/alexa-app 0.2.2 seems to work (but obviously isn't ideal). Versions 0.2.3+ seem broken, likely due to these changes: https://github.com/develpr/alexa-app/compare/0.2.2...0.2.3
Lumen 5.1.7 and develpr/alexa-app 0.2.7 play nicely if https://github.com/develpr/alexa-app/blob/0.2.7/src/Provider/LumenServiceProvider.php#L18 is changed accordingly: ``` diff - $this->app->instance('app.middleware', $this->gatherAppMiddleware($reflection)); + $this->app->instance('alexa.router.middleware', $this->gatherAppMiddleware($reflection)); ```
So yeah, I'm not a Laravel/Lumen expert by any means, but it almost seems like this library simply isn't compatible with Lumen 5.2. Would you have any objections to making...
I've ended up switching to Laravel and it does indeed work perfectly. Not sure if you want to keep this open (should others be interested in fixing this).
> $nestedPath is null, so this line `return null === $nestedPath ? $nestedPath : "$currentProperty.$nestedPath";` returns null It is possible that this code should return `$currentProperty` whenever `null === $nestedPath`?...
I really like this proposal! Let's do it :) > I believe this has to do with the [League\CommonMark\Util\RegexHelper::PARTIAL_ATTRIBUTEVALUESPEC constant](https://github.com/thephpleague/commonmark/blob/5af699c47955345e14f66f3863ff7db48dcd90a2/src/Util/RegexHelper.php#L50) enforcing the presence of an equals character (=) and a...
Thanks for raising this issue! Unfortunately, proper RTL support hasn't been introduced into the CommonMark spec yet :-/ For example, there's a [known issue where using the RTL mark can...
This suggestion makes sense to me. I'd recommend we create a separate extension for it, perhaps called `LimitHeadingsExtension` or something similar. That extension could [observe the `DocumentParsedEvent`](https://commonmark.thephpleague.com/2.4/customization/abstract-syntax-tree/#documentparsedevent) and run some...
This type of issue tends to happen when tabs are used for indentation and we forget to advance the cursor by column (instead of by character). This should be a...