Colin O'Dell

Results 29 issues of Colin O'Dell

We will drop PHP 7.4 support in our 3.0 release

do not close

See https://github.com/thephpleague/commonmark-extras/issues/19

enhancement
do not close

I really liked how v1 had no external dependencies. In v2 we opted to pull in some dependencies instead of reinventing the wheel. I think this was a good decision,...

do not close

This library makes heavy use of regular expressions. While most of them _should_ be fairly performant, there could certainly be some room for improvement to help improve the performance of...

up-for-grabs
performance
do not close
hacktoberfest

There are several rendering-related ideas I'd like to explore for v3: - [ ] Avoiding recursion (parsing and AST iteration already avoid recursion) - [ ] Using an `OutputWriter` object...

enhancement
performance
do not close

#419 and #511 require the ability to render the AST to Markdown. If we also add the ability to parse HTML into the AST then we could replace league/html-to-markdown with...

enhancement
do not close

It may be possible to optimize the `Cursor` implementation by relying more heavily on byte positions internally than character positions. It's possible that character positions could be eliminated completely if...

performance
do not close

[The `creator` parameter seems to accept a string](https://github.com/PyGithub/PyGithub/blob/001970d/github/Repository.py#L2495), but the `Repository.pyi` stub does not show this as an allowed type, which results in mypy errors when a string is used....

## Summary It seems that this polyfill incorrectly case-folds the `ẞ` character to `ß` instead of `ss`. ## Details Running this code on PHP 7.3 with `mbstring` installed: ```php echo...

It would be great if this bundle allowed custom log formats using [Guzzle's `MessageFormatter` class](https://github.com/guzzle/guzzle/blob/master/src/MessageFormatter.php#L12). For example, I have the need to log the full request including the headers and...

enhancement