Colin O'Dell
Colin O'Dell
I've successfully created a very basic proof-of-concept (with minimal changes to the existing parsing/rendering logic) that converts Markdown -> AST -> Markdown with ~98% accuracy in my limited tests. There...
I was originally aiming for July 2022 but I don't have a specific release date yet - it'll be whenever [these 5 tasks](https://github.com/thephpleague/commonmark/milestone/19) in the milestone are implemented. I would...
> I do realise that PHP 7.4 itself is officially supported until 28 Nov 2022, as per https://www.php.net/supported-versions.php - so I feel league/commonmark should support PHP 7.4 at least until...
Sorry for not seeing the original issue report! I agree with @pandymic, this is expected behavior. Ideally, the resulting Markdown _should_ return the same HTML when you run it through...
This is looking great so far!
This is related to #419 as both would require rendering the AST to Markdown
Dumping some of my initial thoughts here: - The parser should look for both Unicode character and `:+1:`-type syntax create an `Emoji` inline element in the AST - The renderer...
Thank you for that detailed analysis, @iksaku! And for pointing out some of the edge cases we need to be careful about. Overall, I think this is the right approach.
> We could start by going with a class-based approach, in which we could define constant unicodes and map them to specific shortcuts, like Github's. This way, we could keep...
Thinking about this more, I believe we need the following features/components in our implementation: ## AST Nodes We'll need two AST nodes: - A `UnicodeEmoji` node to represent emoji defined...