Christian Oliff
Christian Oliff
Accessibility Report: I raised concern about including this before but I don't think this 'hold down button' paradigm is accessible at the moment. - Right now holding down the button...
@ElishaSamPeterPrabhu Maybe the modus-button should have `icon-only` on it e.g. `icon-only="add"` ?
...or instead use some custom CSS like: `height: 28px; width: 28px; padding: 8px; margin-left: 8px`
> Is this the expected look? not exactly, I just included that CSS as a starting point which improves things somewhat.
Yes your draft PR does fix the issue. Nice!
I think this is all already taken care of with an open PR: https://github.com/twbs/bootstrap/pull/40706 Also, you shouldn't commit any changes to the dist/ directory when making a PR.
> @coliff Can you remove this from the icon template (IconFunctionalComponent.template.ejs) in generate-icons folder and make sure the generated icons doesn't have this attribute I don't think I can do...
1. Please change inputmode to `decimal` (not `numeric`). 2. Please fix this accessibility error. 
> Including the cleave-zen library the input is required to have type text , hence the aria attributes like > > ``` > aria-valuemax={this.maxValue} > aria-valuemin={this.minValue} > aria-valuenow={this.value} > ```...
The number input PR is good in many ways, but I have some concerns... Demo: https://deploy-preview-2634--moduswebcomponents.netlify.app/?path=/docs/user-inputs-number-input--default - It uses the input type="text" now instead of type="number", so user can't use...