modus-web-components icon indicating copy to clipboard operation
modus-web-components copied to clipboard

Remove unneeded `xmlns="http://www.w3.org/2000/svg"` from inline SVGs

Open coliff opened this issue 1 year ago • 3 comments

Description

Remove unneeded xmlns="http://www.w3.org/2000/svg" from inline SVGs Saves a few bytes = tiny performance improvement

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update

How Has This Been Tested?

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

coliff avatar Aug 15 '24 11:08 coliff

Deploy Preview for moduswebcomponents ready!

Name Link
Latest commit 1da90804b46702b0d2f3f1692f908af6df3999e3
Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66bdf08c031a09000845c62d
Deploy Preview https://deploy-preview-2792--moduswebcomponents.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 23 (🔴 down 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 15 '24 11:08 netlify[bot]

@coliff Can you remove this from the icon template (IconFunctionalComponent.template.ejs) in generate-icons folder and make sure the generated icons doesn't have this attribute

prashanth-offcl avatar Aug 16 '24 07:08 prashanth-offcl

@coliff Can you remove this from the icon template (IconFunctionalComponent.template.ejs) in generate-icons folder and make sure the generated icons doesn't have this attribute

I don't think I can do that right now. The icons imported from npm have the xlmns attribute (as its needed for standalone SVGs).

For now with this PR all tests pass and it works as intended, so I suggest we merge this as it is and potentially look to remove the xmlns as part of the build-icons script in a separate PR.

coliff avatar Aug 16 '24 07:08 coliff