Christian Oliff

Results 245 comments of Christian Oliff

Good suggestion! I think this would be better handled by the main HTMLHint code rather than just the VS Code extension so I'll migrate this issue over there.

I maintain HTMLHint and approve of this PR. :-) There are no breaking changes since v1.1.4 and many helpful new (optional) rules have been added.

Great PR. I just tested this in a StackBlitz with the CSS generated from the deploy preview. https://stackblitz.com/edit/bzr9zn?file=index.html Separate issue I spotted though is that text is cropped on the...

I can reproduce the issue on this URL: https://getbootstrap.com/docs/5.3/examples/checkout/ It only shows the smaller font size when selecting an autofill and changes to correct size without needing any user interaction....

> When are you going to deprecate the previous `esbenp.*`? It is confusing that the previous one shows at the top of the search result in VS Code. ~The README...

Because the new version is intentionally not promoted because the new version isn't stable yet - it's still in testing. Once it's ready it will be much more visible and...

> If so I think that you can add a red-background "Preview" label at the right to the package name. Have you not seen ones in other extensions? Yes, I...

I agree that isn't annoying... I've never liked the time picker component and think it'd be better to use the OS built `input="time"` instead (which is what MWC v2 does)....

The Translate scenario isn't necessarily translating **_from_** English though, the source of the site could be anything, like Ukrainian or Vietnamese (for example)... and it's not just Google Translate, all...

was just reading @ericwbailey post '`aria-label` is a code smell' and reminded me to revisit this pull request. There's plenty of reasons why a text label is preferable. https://ericwbailey.website/published/aria-label-is-a-code-smell/