Christopher Gross

Results 15 issues of Christopher Gross

Added new "coverage" module and made changes to enable the SonarQube/Jacoco code coverage reports. Uses a local SonarQube instance to keep track of the coverage report. It can run in...

Integration Tested

Dependency analysis runs in gitlab updated structure to remove most "unused declared" and "used undeclared" dependencies. A few still remain that are used that the tool falsely identifies as unused....

This fixes most of the Blocker level issues found by SonarQube. A few will require more substantial refactoring or redesigning of the code, so those will remain as they are....

Integration Tested

clears up a number of simple warnings that occur during the build. (another ticket will cover more of the complex ones that would need a bit of refactoring)

There are a lot of build warnings. Some are pretty straight forward to fix - this ticket will handle those. A few will require more refactoring or major changes, and...

Added a check to ensure the datawaveStart/Stop scripts aren't run as root.

- Interrupted exceptions should be rethrown OR method should be re-interrupted (see https://cwe.mitre.org/data/definitions/391) - Method parameters should not be used for synchronization (see MITRE, CWE-412 - Unrestricted Externally Accessible Lock...

fresh batch of critical issues found by sonarqube

Fix (or detrmine non-issue) ~200 Major issues found in sonarqube Includes: - https://cwe.mitre.org/data/definitions/391 (Interrupted exceptions caught, not re-thrown) - https://wiki.sei.cmu.edu/confluence/x/SjdGBQ (Use atomic variables) - Spots where NPE can be thrown...

fix up the "critical" issues found by sonarqube. bugs and some code smells

Integration Tested