Cody Oss comments

Results 276 comments of


                                            Cody Oss

proposoal: NewController() should take options

@poy Did you have examples of options that you would like to see?

proposoal: NewController() should take options

Example of an option: #246

Order of calls is enforced when `InOrder()` or `After()` were not invoked

Thanks for the issue, I will take a look!

EXPECT fails when using type derived from map

@jtyers Can you please share the versions were this both did and did not work(mockgen)?

EXPECT fails when using type derived from map

Thank you for all the information that helps! Yes is seems like our type checking might be too strict. My guess with out looking at the code is we need...

Loading input failed: failed parsing source file internal/handler/handler: open internal/handler/handler: The system cannot find the path specified.

I am unable to reproduce this. Can you please create a small sample repo to reproduce this? I made this folder structure and it generated to mock.

proposal: Add a new matcher which return true if it matches one of given value

Thanks for the feature request. I think this sounds pretty similar to the feature implemented here: https://github.com/golang/mock/commit/0cdccf5f55d777b12c1ac5a93f607cdd1dbf5296 I am not sure it this is needed as well. What do you...

proposal: Add a new matcher which return true if it matches one of given value

Thank you for the clarification. I will leave this issue open for a bit to see what others think. In the meantime you can always implement this matcher for yourself.

proposal: Add a new matcher which return true if it matches one of given value

I will leave this issue open a little longer, but generally before adding a new matcher I like to see others in the community also asking for the feature. As...

mockgen should not follow type aliases

I agree with the intent of this issue, and this is how is actually does work in source mode. I have not looked into the complexity of the issue, but...