Cody Oss

Results 268 comments of Cody Oss

I am not sure any changes should be made here without going to an update to aip.dev. This kind of change should be driven from a design that all of...

I did bring this up with relevant parties today, still more discussion to be had. I think we should wait for changes to official docs or until we have a...

@anniefu You can use the official sample to reproduce: https://github.com/GoogleCloudPlatform/golang-samples/blob/c732e8f9ceebeaab0493c0a8b574588f38071196/functions/functionsv2/helloworld/hello_world.go#L18-L34 Just run a `go mod vendor` before deploying. Although it is true I depend on the module, Go's dep resolution...

True, and this was always required for gen1 when vendoring, but before #99 users did not have to do this for gen2 with declarative syntax as the package they used...

Sounds good, I think it still might be a good idea to move the "_ import" into the functions package so users don't have to have to add it in...

I think this is close being done. The test in the package no longer needs `aux_files` at least. I need to do a little more research to know if we...

I would love to hear from users here. The tests we currently have in the library that involve `aux_imports` no longer need the flag. If you are currently using this...

@Botono I believe this case is now fixed, at least on HEAD. I believe all cases were aux_files was needed should now be gone. Unless I hear from users others...

@intoxicated @mpyw This is fixed on HEAD. Please try with v1.7.0-rc.1 and let me know if you still have issues

@cccccccccy Can you please provide code to reproduce?