proposoal: NewController() should take options

[poy]

There are a few features that would be best if they were opt in, whether this be for backwards compatibility or simply preference.

An established pattern for configuring something beyond sane defaults is a variadic list of options (see grpc-go for an example).

NewController(t TestReporter, opts ...ControllerOption){
 // ...
}

[msabramo]

Can this issue be closed?

[profsmallpine]

@balshetzer This opens the door to add some nice improvements to the error messages, which has been very difficult for my team to grok after we switched from a super basic in house mocking system. We were hoping to make some improvements, but many of the open pull requests do not seem to get any attention. Can you provide any clarity on how to move PRs through and if we were to invest in some changes, could we do so and see PRs merged or is there just not enough time for whoever is managing this project?

[poy]

@profsmallpine Please feel free to open an issue to discuss and propose what you are needing. From there, we should be able to sort out what PRs we should do.

I'm going to start carving out more time to ensure PRs aren't just sitting :)

[poy]

@msabramo This has not actually been fixed yet. The commit referencing this issue was in poy/mock and not golang. I wasn't happy with it, so I never made the PR.

[codyoss]

@poy Did you have examples of options that you would like to see?

[poy]

A few that come to mind:

• Reversing the order in which mocks are registered (to match gmock for example)
• Reporting styles (verbose vs quiet)

[codyoss]

Example of an option: #246