Cody Oss comments

Results 288 comments of


                                            Cody Oss

monitoringpb: types for cloudRun, gkeNamespace, gkeWorkload and gkeService are missing

Sorry for the late reply. You are correct. I have opened an internal bug so that these libraries get updated. Bug: 333572983

use numeric enum values in routing headers and REGAPIC urls

Will add a test and report back if this is indeed something that requires code changes.

cloud.google.com/go/vertexai: nil pointer dereferencing GenerateContentResponseIterator

cc @eliben @jba

all: do not hide original error code

This is raised as a bigquery issue, but I think that it is likely an issue in all of our gapics. We just fixed a similarish issue recently on the...

all: do not hide original error code

I am going to transfer this issue over to gax-go, seems like a reasonable request to me.

all: do not hide original error code

I have dug into this deeper and I think for now we should put this on hold. Although it would be for the better of all, we can't make this...

APIError.GRPCStatus returns "OK" for all http errors.

I think this is better now with grpc 1.55: https://github.com/grpc/grpc-go/releases/tag/v1.55.0 "status: status.Code and status.FromError handle wrapped errors"

gapic: consolidate routing header parsing/injection

We should try to remove the use of regexp compile from the hotpath of api calls as this could be a concern for performance sensitive apis like a GCS read....

Please generate these files with google.golang.org/grpc/cmd/protoc-gen-go-grpc

Hey I am not sure if we are likely to do this anytime soon as this would be a breaking change to everything. Can you please explain the use case...

Please generate these files with google.golang.org/grpc/cmd/protoc-gen-go-grpc

As a workaround you can always generate the files yourself if you need. All public protos are located here: https://github.com/googleapis/googleapis