Cody Oss
Cody Oss
Hey @nyonson thanks for bring this back to my attention. I will look into this some more and get back to you.
This work is unblocked now that there are public protos for the service: https://github.com/googleapis/googleapis/tree/master/google/cloud/identitytoolkit/v2
@googleapis/api-bigtable If this PR is still wanted we should work to get it merged as it is quite old now.
IIRC in this case you need to set the GoogleAccessID field. This can only be detected if you are using an SA or compute for auth. Then you will be...
@tritone Took a quick look at the code and I believe what I said stands. This is all alluded to in the third paragraph of https://pkg.go.dev/cloud.google.com/go/storage#BucketHandle.SignedURL, but maybe we could...
I would take a look at our [testing.md](https://github.com/googleapis/google-cloud-go/blob/main/testing.md) for ideas on how to write tests against packages in this repo.
LGTM to me overall, just one small nit
@googleapis/api-bigtable Let's decide if we want to move forward with this or close out the issue.
@googleapis/api-profiler If this PR is not wanted we should close this out, it is getting quite old.
@telpirion I am not sure if you actually want to label this as a breaking change? If you are doing this there is module renaming and a bunch of other...