Ben Oukhanov
Ben Oukhanov
@dhiller Thanks Daniel. I'll take a look.
@enp0s3 Thanks a lot :) I'll take a look deeply as soon as I can.
> Therefore, we need to replace usage of `CreateVM` with `NewVirtualMachine`. Then update the received `vm` object with the annotations, and with the run strategy, create the VM, and then...
@enp0s3 Thanks for catching this! really appreciated. Can you please review it again?
@enp0s3 @EdDev Seems like the tests are failing again because the annotations were copied from VM to the VMI [1]. I think I'll update this PR to keep `RetryWithMetadataIfModified` function...
> I'm unsure what is causing this failure with the current changes. Can you explain? Maybe you can comment inline on the relevant change/code. Me too, I'm not sure. Currently...
Hi @avlitman @sradco @machadovilaca, can you please help to review it?
/cc @avlitman @sradco @machadovilaca
Maybe @enp0s3 can help us? :pray:
> I've separated the first commit into separate PR #1033 , so we can merge it sooner. Will you rebase once the new PR is merged?