fix: Correctly deploy instance types from URL

[akrejcir]

What this PR does / why we need it: This PR fixes 2 issues:

• When setting, unsetting, and setting again the .spec.commonInstancetypes.URL field, resources would not be deployed when URL is set for the second time. This was because the URL was cached the first time and not cleared.
• When instance types were deployed from URL, the operator would not revert any changes to them.

Release note:

None

[akrejcir]

/cc @0xFelix @codingben @jcanocan

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from akrejcir. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[akrejcir]

Now I'm not sure if it was intentional that resources from URL are not reconciled. Let's wait for @lyarwood .

/hold

[akrejcir]

I've separated the first commit into separate PR #1033 , so we can merge it sooner.

[openshift-ci[bot]]

@akrejcir: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-upgrade-functests	8589145c793f06ba86ae918b9540e0e7f9fce3ca	link	true	/test e2e-upgrade-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codingben]

I've separated the first commit into separate PR #1033 , so we can merge it sooner.

Will you rebase once the new PR is merged?

[akrejcir]

I will, but not yet. Let's wait for Lee to know if this PR solves a bug, or if it was intended. I don't want to waste CI.

[codingben]

I will, but not yet. Let's wait for Lee to know if this PR solves a bug, or if it was intended. I don't want to waste CI.

Sure thing. I'd rebase it and mark it as draft to disable CI.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[lyarwood]

Now I'm not sure if it was intentional that resources from URL are not reconciled. Let's wait for @lyarwood .

Thanks for looking at this @akrejcir , I think my issue with continuously reconciling from the same URL was just the cost in building the resources each time. The call to kustomize is not cheap and would definitely slow down the time taken by SSP as a whole to reconcile.

With v0.21 out the door I wanted to finally remove this functionality from SSP anyway for v0.22. We can still land this PR to resolve the set, unset and set use case you set out in the description but for it to be useful we would then need to backport that all the way back to v0.19. I'm not sure it's worth the effort tbh.

[kubevirt-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[akrejcir]

Instance types and preferences were removed in: https://github.com/kubevirt/ssp-operator/pull/1074

[akrejcir]

/close

[kubevirt-bot]

@akrejcir: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.