Ben Oukhanov

Results 115 comments of Ben Oukhanov

The new unit test in this PR is failing because `testvmi` doesn't exist, when it runs. I'll debug it.

Hi @xpivarc @enp0s3 @akalenyu, Luboslav asked to add this new unit test in this PR. Locally it passed successfully, but in the CI it fails because of `testvmi` doesn't exist....

> > Hi @xpivarc @enp0s3 @akalenyu, Luboslav asked to add this new unit test in this PR. Locally it passed successfully, but in the CI it fails because of `testvmi`...

> Unit tests pass on CI now https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/12470/pull-kubevirt-unit-test/1823000813618860032 Yep I see, this is awesome! Thanks @akalenyu @ormergi :)

@enp0s3 @iholder101 I see there is no response from @xpivarc yet. I'd appreciate if current PR can be approved, later another one can be opened to resolve @xpivarc's request if...

Thanks @iholder101 :) @enp0s3 Do you think it looks good?

> > Thanks @iholder101 :) @enp0s3 Do you think it looks good? > > Last push is just a rebase right? Yes, except single conflict that caused by removed `startVM(...)`...

@akalenyu Thanks for catching it so quickly, I missed it during rebase. @enp0s3 Yeah I just pushed it while you was typing it :smile: Thanks!

/test pull-kubevirt-check-tests-for-flakes

> Actually ready/running is overkill here, you just want to see the label and be done with the test Yep I just did it like it was before. Shouldn't we...