Ganesh Vernekar

Results 146 comments of Ganesh Vernekar

~How do you feel about this being a runtime reloadable config via files vs re-using the current CLI flag to enable this feature? Having it in the file will not...

@Nexucis At the current state, I think it makes sense to always show the autocomplete with the message saying this is for the experimental histogram feature. I think this is...

With some offline discussions, since no one is asking for protobuf scraping actively, we decided to enable protobuf scraping iff histograms are enabled. Else it stays disabled by default.

> In which case are overlapping blocks not a bug in regular Prometheus? There can be some unknown races in TSDB that can make blocks overlapping (very rare and idk...

Also I think it helps in ease of use when working with out of order and backfilling, you don't have to do an extra step of enabling overlapping blocks (while...

Maybe related in coming up with an overall improvement: https://github.com/prometheus/prometheus/blob/7feea8aa894da5f16d41935538d2bf6ffb55050f/storage/buffer.go#L167

@kadaan thats awesome. I wonder if you would be willing to contribute it to Prometheus upstream? I think it is a useful feature to have. The API work and the...

I guess it is time for a rebase 👀, thanks for both the PRs!

I have updated the description with all the different things that we need unit tests for (some already exist). I will update the list if I find something that was...

@beorn7 only the UI test is pending in this. What's our plan? @Nexucis do you think you will be able to assist us in this?