Ganesh Vernekar

Results 146 comments of Ganesh Vernekar

Do you mean to say drop both checkpoint and also the WAL? (btw, in that case, we should also remove the data from the memory)

Hold on before working on this. https://github.com/prometheus/prometheus/issues/7530#issuecomment-655393626 makes sense and need to re-think this. If checkpoint is corrupt, replaying WAL for partial series might not be useful/meaningful.

Hold on before working on this. https://github.com/prometheus/prometheus/issues/7530#issuecomment-655393626 makes sense and need to re-think this. If checkpoint is corrupt, replaying WAL for partial series might not be useful/meaningful.

In ~Prometheus Storage Working Group~ contributors office hours we wen't over these 3 options of how we want to handle this 1. Drop everything from Head since there will be...

Then that sounds like option 1. Also, checkpoint corruptions should be rare, it will only happy if disk is faulty and not on Prometheus crashes.

To not block this any further, let's go with the simpler option 1, and we can revisit this later if that is causing any problems.