Ganesh Vernekar comments

Results 146 comments of


                                            Ganesh Vernekar

Replay WAL concurrently without blocking

Apologies in the delay. I plan to review it tomorrow. Thanks for your patience!

Replay WAL concurrently without blocking

LGTM with nits above from me and @colega

Replay WAL concurrently without blocking

Nice work!

labels.Labels: reduce memory by storing as a single string

![hooray-letsgo](https://user-images.githubusercontent.com/15064823/177575254-33f61249-2bac-404d-8fee-ab2217070aae.gif)

labels.Labels: reduce memory by storing as a single string

/prombench main

labels.Labels: reduce memory by storing as a single string

Prombench results: There seems to be roughly 10% savings in RSS. Querying is similar, but a little more expensive in the prepare_time (which is where we get the samples from...

labels.Labels: reduce memory by storing as a single string

/prombench cancel

Append metadata to the WAL in the scrape loop

I plan to review the tsdb changes sometime next week

Append metadata to the WAL in the scrape loop

@tpaschalis Since you are anticipating more metadata fields to come in future, I suggest this WAL format similar to a series which does not assume the field based on it's...

Write & mmap chunks in the background

I see that you have already done some investigation in https://github.com/prometheus/prometheus/issues/10377. Did you have the queue enabled? Did this patch with the queue make the situation better?