Karen Attfield

Results 37 comments of Karen Attfield

This all tests ok, except the error logging. That wasn't working for me so I then noticed by adding error logs in the Jetpack production `site-logo.php` file, it would get...

The moment I switched to Twenty Fifteen, the error log worked correctly. My mistake was choosing a few themes purely based on `feature:site-logo` in WordPress.com. Works well now.

Tests well for me 👍

@kraftbj it looks like this is still in progress?

Calypso update PR: https://github.com/Automattic/wp-calypso/pull/68073 Update and cleanup diff: D88056-code (Calypso PR needs merging before this can be deployed). --- **Testing instructions** * Apply the above diff, and add a Tiled...

Good point, thank you. It seems that was also possible before this solution was implemented as well (albeit not as simply as just swapping a value number, but instead adding...

> would it make sense to have any public and protected methods call through to Automattic\Jetpack\Calypsoify\Jetpack_Calypsoify? It would, thank you! I've edited each relevant function. Edit to add - looks...

Thanks @anomiex ! I've also updated the testing instructions so that should include both testing the class instance, and testing individual functions where possible.

I've not looked through the full list of phan flagged issues, but certainly some look like false positives, eg `Error: UndefError PhanUndeclaredClassConstant Reference to constant MANAGE_PLUGINS from undeclared class \WPCOM_Features`...

> Interesting. I haven't been able to reproduce the issue on a regular AT site. Did you hit the Publish button in the Customizer after checking the option? My AT...