jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

De-Fusion: Sharing

Open sdixon194 opened this issue 3 years ago • 1 comments

Impacted plugin

Jetpack

What

Sharing

How

"$plugin_root/modules/sharedaddy/admin-sharing.css"   => "$wpcom_root/wp-content/mu-plugins/post-flair/sharing/admin-sharing.css",
"$plugin_root/modules/sharedaddy/admin-sharing.js"    => "$wpcom_root/wp-content/mu-plugins/post-flair/sharing/admin-sharing.js",
"$plugin_root/modules/sharedaddy/recaptcha.php"       => "$wpcom_root/wp-content/mu-plugins/post-flair/sharing/recaptcha.php",
"$plugin_root/modules/sharedaddy/sharing-service.php" => "$wpcom_root/wp-content/mu-plugins/post-flair/sharing/sharing-service.php",
"$plugin_root/modules/sharedaddy/sharing-sources.php" => "$wpcom_root/wp-content/mu-plugins/post-flair/sharing/sharing-sources.php",
"$plugin_root/modules/sharedaddy/sharing.css"         => "$wpcom_root/wp-content/mu-plugins/post-flair/sharing/sharing.css",
"$plugin_root/modules/sharedaddy/amp-sharing.css"     => "$wpcom_root/wp-content/mu-plugins/post-flair/sharing/amp-sharing.css",
"$plugin_root/modules/sharedaddy/sharing.js"          => "$wpcom_root/wp-content/mu-plugins/post-flair/sharing/sharing.js",
"$plugin_root/modules/sharedaddy/sharing.php"         => "$wpcom_root/wp-content/admin-plugins/post-flair/sharing.php",
"$plugin_root/modules/sharedaddy/images/"             => "$wpcom_root/wp-content/mu-plugins/post-flair/sharing/images/",

sdixon194 avatar Jul 22 '22 20:07 sdixon194

"$plugin_root/modules/sharedaddy/sharing.php" => "$wpcom_root/wp-content/admin-plugins/post-flair/sharing.php", is quite out of sync.

samiff avatar Sep 28 '22 17:09 samiff

Looks like everything is in sync to me. Did you accidentally compare with wp-content/mu-plugins/post-flair/sharing.php instead of wp-content/admin-plugins/post-flair/sharing.php, since all the rest of the files are in mu-plugins?

anomiex avatar Oct 20 '22 15:10 anomiex

Did you accidentally compare with wp-content/mu-plugins/post-flair/sharing.php instead of wp-content/admin-plugins/post-flair/sharing.php

Probably did since they look in sync to me :)

samiff avatar Oct 20 '22 16:10 samiff

Update diff: D90374-code Cleanup diff: D90378-code

Testing: example.wordpress.com/wp-admin/options-general.php?page=sharing can be checked for the admin loaded resources and sharing options.

samiff avatar Oct 20 '22 22:10 samiff

Tests well for me 👍

coder-karen avatar Oct 21 '22 11:10 coder-karen

Update changeset: r254939-wpcom Cleanup changeset: r254940-wpcom

samiff avatar Oct 21 '22 19:10 samiff