Josh Smith

Results 48 issues of Josh Smith

This way, you can more easily customize routes on a subgrouping level -- such as e.g. applying ratelimits to the `api.` subdomain, or perhaps only `api.{domain}/v2/*`, or maybe even just...

enhancement
Priority 2
developer tooling

At the moment, our server has a couple of locations where objects of types such as `datetime` are not able to be serialized into JSON due to a lack of...

bug
code quality

# Describe your changes ## Related Issues / Projects ## Checklist - [ ] I've manually tested my code

developer tooling

Very similar in nature to #636 -- we should be using the scores repository to fetch this data from the database, rather than looking into the player's active session to...

enhancement
good first issue

When using the command with an offline user, the "logged in" and "last server interaction" are the time since 1970. We should make these more user-friendly -- and e.g. show...

bug
good first issue

Code reference: https://github.com/osuAkatsuki/bancho.py/blob/more-sqlalchemy/app/commands.py#L358-L411 The problem is this line: `player = app.state.sessions.players.get(name=ctx.args[1])`. This only works for online users. Instead, it should be using the users repository to lookup the player from...

bug
good first issue

I wonder if there's much value in keeping this structure here - if so, we should update it in each readme.

documentation

We get this output: ``` Run docker-compose -f docker-compose.test.yml exec -T bancho-test /srv/root/scripts/run-tests.sh Initializing database... ERROR 2002 (HY000): Can't connect to server on 'mysql-test' (115) Error: Process completed with exit...

bug
Priority 0
developer tooling

# Describe your changes ## Related Issues / Projects ## Checklist - [ ] I've manually tested my code

An example from a recent PR: ```py class GrantType(StrEnum): IMPLICIT = "implicit" class ChannelMembership(TypedDict): session_id: str channel_name: str grant_type: GrantType created_at: datetime def serialize(channel_membership: ChannelMembership) -> str: """Serialize a channel...

code quality
triage