Cristian Monforte

Results 84 comments of Cristian Monforte

Same as in https://github.com/duckduckgo/Android/pull/2296, I think something went wrong when aligning between branches. Files changed in this PR contain changes from initial PRs. Could you double check this? Thanks!

@nalcalag I think this PR is not in the right state yet. Checking the files changed, I still see too many that have been already changed in other PRs, can...

About the keyboard issue. We request keyboards don't use anything typed into our app for personalization. It's up to each keyboard to decide how to honor that setting. In your...

Thanks, I've tested it multiple times with different setups and I'm always getting the same emtpy/blank png. This is the latest I tested, and no luck. ``` - name: Android...

I'm playing around with a dummy repository I have. You can take a look to [the run here](https://github.com/cmonfortep/LottieTest/actions/runs/3193315826/jobs/5211753098)

I expect they will work as well, any reason why they shouldn't work? I've also seen people running screenshot tests on headless emulators, I don't think that's an issue. As...

Thanks @mrk-han. We have that in our app, and on my dummy app for testing. Let's see if someone could bring more light here about possible issues around screenshots.

There you go: https://github.com/cmonfortep/LottieTest How to reproduce: - Open the app - click on Play animation - change system theme - app crashes Notice something important: We set the assetDelegate...

I can't reproduce it on my device/emulators. Also, colors when using dark theme system + light app theme look weird (e.g: DuckDuckGo should be white in dark theme) I see...

Not sure we have that enabled in our app according to the docs "Apps must opt-in to Force Dark by setting android:forceDarkAllowed="true" in the activity's theme. "