Cristian Monforte
Cristian Monforte
@droid-it sounds great
@droid-it done. Please use as a reference some of our migrate fragments. https://github.com/duckduckgo/Android/pull/1329 we introduced a fragment viewbinding delegate to make viewbinding in fragments easier.
@mslalith I've just noticed we still have some adapters and dialogs using kotlin synthetics: FireproofWebsitesAdapter, LocationPermissionsAdapter, and FireDialog. Could you submit a PR to migrate those pending classes?
You can work on any of the ones we haven't yet migrated (except browserTabFragment which we will refactor internally since it's too complex)
Thanks for reporting and sharing that website as an example. We knew about websites having bottom-anchored content being affected, but this one is a different and totally valid use case...
Information for possible contributions: The issue is that the web view can actually off be positioned partially offscreen depending on the scrolling. When you scroll the page, the toolbar slides...
Hi @garygreen, by "this one is different" I didn't want to say it's another problem, but a new scenario that we didn't know about. Both issues are affected by the...
Tracking this internally: https://app.asana.com/0/0/1187616573788673/f
Go for it! We are tracking this issue internally, but we haven't had time to work on that yet.
Thanks, we have created a task to investigate this issue. https://app.asana.com/0/414730916066338/1200093361360408/f