apache
MINOR: Don't log missing partitions at ERROR level
What
We are logging missing partitions as errors in the state.change.logger which may be a bit alarming. There are valid cases where the partition may not exist, eg: partition reassignment.
Testing
Verified that ReassignPartitionsIntegrationTest logs partition reassignments at error without the patch and doesn't with the patch.
Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
Perhaps we should just lower the priority to INFO instead of ERROR? I do think it's nice to know when we create a new log directory.
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)
If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Perhaps we should just lower the priority to INFO instead of ERROR? I do think it's nice to know when we create a new log directory.
That makes sense to me. We can keep only stateChangeLogger.info(s"Creating new partition $tp with topic id " + s"$topicId.") to simplify PR. @splett2 WDYT?
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)
If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.