Christoph M. Becker
Christoph M. Becker
I see more stripes in the "before" image than in the "after" image. However, dithering might not be relevant any longer (probably only useful for GIF, and even there it...
We're already working on improving Windows support, see issue #249. [Near the end of the current discussion](https://github.com/libgd/libgd/issues/249#issuecomment-234561234) you may find some helpful info for building the DLLs on Windows yourself....
I had a closer look at this, and the question is which VC runtimes should be supported. The dependendencies on http://windows.php.net/downloads/php-sdk/deps/ only support VC11 and VC14, but besides the [inline...
And there is yet another difference: if auto-cropping crops nothing or the complete image, PHP's bundled libgd would not even call `gdImageCrop()`, but [return `NULL`](https://github.com/php/php-src/blob/php-7.3.0RC6/ext/gd/libgd/gd_crop.c#L166-L168) instead, which is a nice...
Thank you! Looks generally good to me, but maybe it's better to split the CMake/pthread changes into a separate PR?
It may make sense to use the same terms: gdSetMemoryCallocMethod vs. gdCallocf. Why not gdCallocMethod? Or gdSetMemoryCallocFunc and gdCallocFunc.
> I think it would make sense to have a struct, it will also helps CPU cache, especially in loaders where quite a few alloc/free may happen. Or in GD3...
Adam Harvey already supplied a respective reproduce script including a respective font file and actual and expected images in the [respective PHP bug report](https://bugs.php.net/bug.php?id=51135), and the first halve of the...
@pierrejoye Indeed there is issue #184, which would be a nice enhancement. Wrt. this issue, it seems that in the long run we can simplify [finding the desired charmap](https://github.com/libgd/libgd/blob/gd-2.2.3/src/gdft.c#L1101-L1168) by...
Thanks, Mike! I'll give FontForge a try.