Christoph M. Becker
Christoph M. Becker
I don't know much about color profiles, but I wonder whether color calculations can be done without regarding the color profile, but later attach that profile again. I also wonder...
> we should double check Visual Studio status and probably formalize that supported version too. This is slightly tricky, since it seems that MS never will fully [support C99, but...
For building and running the test suite, we have only travis.org (Linux and macOS). I think we'll need to change that soonish.
Travis gives some credits to open source projects, but when these have been spent, you need to purchase new credits. Not sure if anybody will sponsor this. Github actions may...
Thanks! That would solve #341. Just a few quick remarks: * if we apply auto-rotation/flipping, there should be a way to detect whether this happens; a constant may be sufficient...
Sure, I can submit a PR, but wouldn't know against which branch. It seems to me, that master is more likely to become GD 2.3, and we can't change the...
The [PHP implementation](https://github.com/php/php-src/blob/3f890635aec20e09373da16a736eb01a1d579b1e/ext/gd/libgd/gd_crop.c#L295-L304) is now the same as ours: https://github.com/libgd/libgd/blob/1e47a89a65d49a9003d8365da4e26a7c1a32aa51/src/gd_color.c#L13-L22 But that is still not as it ought to be. I can provide a PR soonish.
The background is supposed to be transparent. How that is displayed, depends on your image viewer.
It's certainly a good idea to add further architectures to our CI. Wrt. the failing test: that is not unexpected. Freetype can produce slightly different results depending on version, configuration...
Well, https://cmb69.github.io/pdiff/index.html might be starting point. :)