Christoph M. Becker

Results 597 comments of Christoph M. Becker

After further consideration, I don't think that we should change the differing behavior with regard to alpha of the different quantization methods. Particularly, adding full alpha transparency support to GD_QUANT_JQUANT...

Yes, that sounds good to me either. We should not forget about https://github.com/libgd/libgd/blob/0f9dd9627aa9f5095164a73e84905bb4af4bfc8f/src/gd_interpolation.c#L95-L120 Maybe we should drop that altogether, or at least use int64_t instead of long on 64bit (for...

I'm not sure whether this is a good idea; at least we shouldn't run that for each commit, but rather nightly or so. An alternative would be to do that...

Yeah, but there may be a performance issue. Currently our CI is quite fast (a few minutes); building php-src and runnings its gd test suite certainly takes longer. And while...

Thanks for reporting here! IMHO, the biggest issue is the misleading error message: "gd-webp cannot allocate temporary buffer". At the very least we probably should check for the "VP8X" chunk...

Indeed, there is no support for EXIF data yet.

There is issue #343 which requests support for lossless transformations, and issue #344 which is concerned with retaining the EXIF data. So I'm changing this ticket to request auto-rotation according...

It seems that GD-2.3 has already been branched. Any objections to merge this into master?

See also https://bugs.php.net/bug.php?id=74808.

> bug isn't public The report doesn't really add new info. :) > I'm worried about changing the allocation methods during application runtime, […] I think that would be a...