Craig MacKenzie

Results 244 comments of Craig MacKenzie

We can have the shipper publish a Docker image as part of it's CI process and just consume that in the beats build as we do for the other outputs...

https://github.com/elastic/elastic-agent-shipper/issues/60 is a test of the shipper process in the shipper repository. This issue is a test of the Beats shipper client in the Beats repository. They will need to...

It may make sense to wait for the completion of https://github.com/elastic/elastic-agent-shipper/issues/161 before implementing this, as the shipper configuration format is going to change significantly when that issue is completed. If...

@elastic/obs-cloud-monitoring this is the first time I've seen a test failure for `Extended / x-pack/filebeat-cloudAWS / Test_StorageClient/TwoContainersWithoutPoll_NoErr`, I assume this is one of your tests? Did something change recently that...

Thanks, I saw Azure and assumed cloud monitoring. @ShourieG you were the last person to touch this input (https://github.com/elastic/beats/pull/33112), do you recognize this test failure?

Can you start filebeat with profiling enabled and capture a CPU profile (ideally more than one) with the slow processors running? That will tell us where filebeat is spending its...

Awesome, thanks! All three CPU profiles look similar which is good. Here's a flamegraph from the first profile: I see a bunch of time being spent formatting error messages in...

This is the code path contributing to a large part of the slowness here: https://github.com/elastic/beats/blob/4a71e5e7eb8faa711785aee434a2aadd248439e0/libbeat/processors/actions/drop_fields.go#L68-L81 We are building a slice of errors, so the more errors there are the more...

Yes, I was just about to suggest that. If it is still slow try and capture another profile if it isn't too much work, the problem is much easier to...

> I suppose go/the processors doesn't have something along the line of if log.isDebugEnabled { do_error_reporting } to avoid constructing them if they're never logged? No, processor error handling can...