Craig MacKenzie

Results 244 comments of Craig MacKenzie

Thanks everyone, merging this with 8.5 as the target version. We can have our QA team check this on a few different versions of Windows as a final sanity check.

Looking at the [Go 1.18 release notes](https://tip.golang.org/doc/go1.18#tls10), for the beats test failures we are being affected by: > Rejecting SHA-1 certificates crypto/x509 will now reject certificates signed with the SHA-1...

> Elasticsearch header transformations. The V1 AST transformations, now gone in V2, have a InjectHeadersRule that will modify the header config of an elasticsearch output. These headers were obtained via...

With a review this big it would be nice if we could separate out the linter fixes in the diff. You might be able to factor/rebase out the commits if...

For the beats in this repository that are [supported by agent](https://github.com/elastic/elastic-agent/tree/main/internal/spec) that are not metricbeat or filebeat: - Heartbeat, Osquerybeat, and Packetbeat all already understand the agent policy configuration format...

@eyalkraft and @axw can you review this PR introducing the agent V2 protocol to beats to assess the impact on Cloudbeat and APM server respectively? I know you both depend...

@axw > When is this going to land? Is it possible to keep V1 while introducing V2? We will need some time to adjust APM Server, and this isn't something...

I confirmed with Blake that there likely aren't any changes to make in APM server because of the move from V1 to V2 spec files. APM should just need the...

> with all the various blockers and adjacent issues, at what point do we want to merge this? Wait until CI is fully working? Wait until the agent issues are...